seg rm-state: delete .tmp files from snapshot directories#19549
Merged
AskAlexSharov merged 1 commit intomainfrom Mar 2, 2026
Merged
seg rm-state: delete .tmp files from snapshot directories#19549AskAlexSharov merged 1 commit intomainfrom
AskAlexSharov merged 1 commit intomainfrom
Conversation
DeleteStateSnapshots now unconditionally removes .tmp files from all 7 snapshot directories (Snap, SnapIdx, SnapHistory, SnapDomain, SnapAccessors, SnapCaplin, SnapForkable). These are artifacts from incomplete or cancelled operations and should always be cleaned up. The cleanup respects --dry-run mode and is not subject to --step, --latest, or --domain filters. Closes #18789
sudeepdino008
force-pushed
the
bridge/erigon-18789-datadir-rm-state
branch
from
c276621 to
2965899
Compare
AskAlexSharov
approved these changes
Mar 2, 2026
sudeepdino008
added a commit
that referenced
this pull request
Mar 4, 2026
## Summary - `DeleteStateSnapshots` now unconditionally removes `.tmp` files from all 7 snapshot directories: `Snap`, `SnapIdx`, `SnapHistory`, `SnapDomain`, `SnapAccessors`, `SnapCaplin`, `SnapForkable` - `.tmp` files are artifacts from incomplete/cancelled operations and were previously skipped because `ParseFileName()` cannot parse them - Cleanup respects `--dry-run` mode and is not subject to `--step`, `--latest`, or `--domain` filters ## Test plan - [x] `Test_DeleteStateSnaps_RemovesTmpFiles`: verifies `.tmp` files across all 7 directories are cleaned up - [x] `Test_DeleteStateSnaps_DryRunKeepsTmpFiles`: verifies dry-run mode preserves `.tmp` files Closes #18789
sudeepdino008
added a commit
that referenced
this pull request
Mar 4, 2026
## Summary - `DeleteStateSnapshots` now unconditionally removes `.tmp` files from all 7 snapshot directories: `Snap`, `SnapIdx`, `SnapHistory`, `SnapDomain`, `SnapAccessors`, `SnapCaplin`, `SnapForkable` - `.tmp` files are artifacts from incomplete/cancelled operations and were previously skipped because `ParseFileName()` cannot parse them - Cleanup respects `--dry-run` mode and is not subject to `--step`, `--latest`, or `--domain` filters ## Test plan - [x] `Test_DeleteStateSnaps_RemovesTmpFiles`: verifies `.tmp` files across all 7 directories are cleaned up - [x] `Test_DeleteStateSnaps_DryRunKeepsTmpFiles`: verifies dry-run mode preserves `.tmp` files Closes #18789
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeleteStateSnapshotsnow unconditionally removes.tmpfiles from all 7 snapshot directories:Snap,SnapIdx,SnapHistory,SnapDomain,SnapAccessors,SnapCaplin,SnapForkable.tmpfiles are artifacts from incomplete/cancelled operations and were previously skipped becauseParseFileName()cannot parse them--dry-runmode and is not subject to--step,--latest, or--domainfiltersTest plan
Test_DeleteStateSnaps_RemovesTmpFiles: verifies.tmpfiles across all 7 directories are cleaned upTest_DeleteStateSnaps_DryRunKeepsTmpFiles: verifies dry-run mode preserves.tmpfilesCloses #18789